HomePhabricator
Diffusion Comm 9fd2d2a2b075

[native] [22/40] RN 0.70: Get rid of comm-react-native-codegen

Description

[native] [22/40] RN 0.70: Get rid of comm-react-native-codegen

Summary:
Before the preceding diff, we had CommCoreModule's codegen (yarn codegen-jsi) using a different version of react-native-codegen than the transitive dependency from react-native. The versions started drifting when we introduced comm-react-native-codegen beacuse we wanted to patch our usage of react-native-codegen without affecting the primary version.

After making the versions of both react-native-codegens match again in the preceding diff, I started seeing this Yarn issue: https://github.com/yarnpkg/yarn/issues/7509

In that diff I also removed the patchfile. Given we don't need the patchfile anymore, we can circumvent the Yarn issue by replacing comm-react-native-codegen with a normal react-native-codegen dependency.

Test Plan:
Tested along with whole stack: test plan

Depends on D5915

Reviewers: marcin, tomek, bartek, kamil

Subscribers: atul

Differential Revision: https://phab.comm.dev/D5916

Details

Provenance
ashoatAuthored on Nov 11 2022, 5:09 AM
Differential Revision
D5916: [native] [22/40] RN 0.70: Get rid of comm-react-native-codegen
Parents
rCOMMf194419ed81f: [native] [21/40] RN 0.70: Update comm-react-native-codegen
Branches
Unknown
Tags
Unknown