Page MenuHomePhabricator
Differential D5922

[native] [27/40] RN 0.70: Patch react-native-camera to fix ViewPropTypes crash
ClosedPublic
Actions

Authored by ashoat on Dec 18 2022, 7:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 25, 11:42 AM
Unknown Object (File)
Sat, Mar 15, 7:22 AM
Unknown Object (File)
Sat, Mar 15, 7:22 AM
Unknown Object (File)
Sat, Mar 15, 7:22 AM
Unknown Object (File)
Sat, Mar 15, 7:22 AM
Unknown Object (File)
Sat, Mar 15, 7:22 AM
Unknown Object (File)
Sat, Mar 15, 7:22 AM
Unknown Object (File)
Sat, Mar 15, 7:22 AM
View All Files
Subscribers
atul

Details

Reviewers
tomek
bartek
Commits
rCOMMf4d6e6abba09: [native] [27/40] RN 0.70: Patch react-native-camera to fix ViewPropTypes crash
Summary

Our old version of react-native-camera was erroring due to an import of ViewPropTypes from react-native, which has been deprecated. I tried to update it, but that didn't fix the issue, so I added a patch. Then I realized the update broke the Android build, so I took it out.

This package appears to have been deprecated sometime in the last year. ENG-1520 tracks the long-term solution, but I don't have the cycles to handle that right now unfortunately.

Depends on D5921

Test Plan
  1. Confirm JS error due to ViewPropTypes import no longer occurs
  2. Tested along with whole stack: test plan (includes testing camera functionality)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Dec 18 2022, 7:53 PM
Herald added a subscriber: atul. · View Herald TranscriptDec 18 2022, 7:53 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 18 2022, 7:53 PM
Harbormaster failed remote builds in B14251: Diff 19490!
ashoat added a child revision: D5923: [native] [28/40] RN 0.70: Fix Expo 47 SecureStore crash on Android.Dec 18 2022, 7:57 PM
ashoat retitled this revision from [native] [26/40] RN 0.70: Patch react-native-camera to fix ViewPropTypes crash to [native] [27/40] RN 0.70: Patch react-native-camera to fix ViewPropTypes crash.Dec 18 2022, 8:05 PM
ashoat updated this revision to Diff 19511.Dec 18 2022, 8:19 PM

Rebase

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 18 2022, 8:32 PM
Harbormaster failed remote builds in B14272: Diff 19511!
ashoat updated this revision to Diff 19538.Dec 18 2022, 8:32 PM

Rebase

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 18 2022, 8:58 PM
Harbormaster failed remote builds in B14299: Diff 19538!
ashoat updated this revision to Diff 19600.Dec 19 2022, 8:22 AM

Rebase

ashoat updated this revision to Diff 19633.Dec 19 2022, 8:38 AM

Rebase

Harbormaster failed remote builds in B14351: Diff 19600!Dec 19 2022, 9:05 AM
ashoat published this revision for review.Dec 19 2022, 9:11 AM

Please ignore CI until the end of the stack

Harbormaster failed remote builds in B14384: Diff 19633!Dec 19 2022, 10:06 AM
ashoat updated this revision to Diff 19706.Dec 19 2022, 12:29 PM

Rebase

Harbormaster failed remote builds in B14451: Diff 19706!Dec 19 2022, 12:39 PM
bartek accepted this revision.Dec 20 2022, 3:30 AM
This revision is now accepted and ready to land.Dec 20 2022, 3:30 AM
ashoat updated this revision to Diff 19764.Dec 20 2022, 6:22 AM

Rebase

Harbormaster failed remote builds in B14507: Diff 19764!Dec 20 2022, 6:26 AM
ashoat updated this revision to Diff 19826.Dec 20 2022, 11:02 AM

Rebase

Harbormaster completed remote builds in B14566: Diff 19826.Dec 20 2022, 11:38 AM
Closed by commit rCOMMf4d6e6abba09: [native] [27/40] RN 0.70: Patch react-native-camera to fix ViewPropTypes crash (authored by ashoat). · Explain WhyDec 20 2022, 12:01 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMf4d6e6abba09: [native] [27/40] RN 0.70: Patch react-native-camera to fix ViewPropTypes crash.

Revision Contents
Changeset List

PathSize
patches/
20 lines

Diff 19867

View Options

patches/react-native-camera+3.31.0.patch

Show First 20 Lines • Show All 130 Lines • ▼ Show 20 Lines
const styles = StyleSheet.create({ const styles = StyleSheet.create({
dummyMessage: { dummyMessage: {
paddingHorizontal: 12, paddingHorizontal: 12,
paddingVertical: 6, paddingVertical: 6,
}, },
message: { message: {
overflow: 'hidden', overflow: 'hidden',
paddingHorizontal: 12, paddingHorizontal: 12,
paddingVertical: 6, paddingVertical: 8,
}, },
text: { text: {
fontFamily: 'Arial', fontFamily: 'Arial',
fontSize: 18, fontSize: 14,
benschacAuthorUnsubmitted
Done
Inline Actions

I actually think this is a bit too small. But that's what's in the design.

https://www.figma.com/file/L675ETKDnGaSwlpZAw4MIC/Mobile-App?node-id=351%3A455

@ashoat - I think 16px looks better.

image.png (1×2 px, 2 MB)

benschac: I actually think this is a bit too small. But that's what's in the design. https://www.figma.
lineHeight: 22,
}, },
}); });
export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement }; export { InnerTextMessage, dummyNodeForTextMessageHeightMeasurement };