Details

Reviewers

tomek
bartek

Commits

rCOMM96720233b3bb: [native] [10/40] RN 0.70: Flow update

Summary

The .flowconfig and package.json changes come from React Native Upgrade Helper. The rest fix Flow errors uncovered by the update.

Historically I've split up Flow changes for a React Native upgrade, but this time there weren't too many!

Depends on D5903

Test Plan

Ran flow and also tested along with whole stack: test plan

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Dec 17 2022, 7:53 PM

Herald added a subscriber: atul. · View Herald TranscriptDec 17 2022, 7:53 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 17 2022, 7:53 PM

Harbormaster failed remote builds in B14233: Diff 19467!

ashoat added a child revision: D5905: [native] [11/40] RN 0.70: Revert "[RN0.66] 41/n: Patch Easing types".Dec 17 2022, 7:54 PM

ashoat added inline comments.Dec 17 2022, 7:58 PM

native/.flowconfig
8 ↗	(On Diff #19467)	Had to add this
native/calendar/calendar.react.js
200 ↗	(On Diff #19467)	Flow errors exposed that we were doing this wrong
native/flow-typed/npm/react-native-reanimated_v2.x.x.js
38 ↗	(On Diff #19467)	Flow didn't like that I was "shadowing" other names on line 487, so I had to change this
native/navigation/disconnected-bar.react.js
29 ↗	(On Diff #19467)	Flow caught a bug here!
native/navigation/tab-bar.react.js
23 ↗	(On Diff #19467)	And here!
patches/react-native-firebase+5.6.0.patch
270–273 ↗	(On Diff #19467)	We had this hack here before to trick Flow into not giving errors, but it's actually not typed correctly. I fixed the type up to actually be correct this time

Please ignore CI until the end of the stack

Fix new Flow error in web/electron.js

Harbormaster failed remote builds in B14255: Diff 19494!Dec 18 2022, 8:14 PM

Rebase

Harbormaster failed remote builds in B14282: Diff 19521!Dec 18 2022, 8:49 PM

Rebase

Harbormaster failed remote builds in B14334: Diff 19583!Dec 19 2022, 8:29 AM

Rebase

tomek accepted this revision.Dec 19 2022, 8:56 AM

tomek added inline comments.

native/media/file-utils.js
158–162	I'm fine with this new version, but just curious: was it required by a new version of Flow?

This revision is now accepted and ready to land.Dec 19 2022, 8:56 AM

Harbormaster failed remote builds in B14367: Diff 19616!Dec 19 2022, 8:57 AM

ashoat added inline comments.Dec 19 2022, 9:42 AM

native/media/file-utils.js
158–162	Yes it was. Flow was afraid that the `console.log` might have some side effect and so `newLocalURI` could become falsey somehow

Rebase

Harbormaster failed remote builds in B14406: Diff 19657!Dec 19 2022, 9:58 AM

Rebase

Harbormaster failed remote builds in B14549: Diff 19809!Dec 20 2022, 11:11 AM

This revision was landed with ongoing or failed builds.Dec 20 2022, 12:00 PM

Closed by commit rCOMM96720233b3bb: [native] [10/40] RN 0.70: Flow update (authored by ashoat). · Explain Why

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM96720233b3bb: [native] [10/40] RN 0.70: Flow update.

[native] [10/40] RN 0.70: Flow update
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 19616

keyserver/.flowconfig

keyserver/package.json

keyserver/src/database/database.js

keyserver/src/updaters/thread-permission-updaters.js

landing/.flowconfig

landing/package.json

lib/.flowconfig

lib/package.json

lib/shared/notif-utils.js

native/.flowconfig

native/calendar/calendar.react.js

native/calendar/entry.react.js

native/flow-typed/npm/@react-navigation/native_v6.x.x.js

native/flow-typed/npm/react-native-reanimated_v2.x.x.js

native/media/file-utils.js

native/navigation/disconnected-bar.react.js

native/navigation/tab-bar.react.js

native/package.json

patches/react-native-firebase+5.6.0.patch

web/.flowconfig

web/calendar/entry.react.js

web/electron.js

web/package.json

web/vector-utils.js

yarn.lock

[native] [10/40] RN 0.70: Flow updateClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 19616

keyserver/.flowconfig

keyserver/package.json

keyserver/src/database/database.js

keyserver/src/updaters/thread-permission-updaters.js

landing/.flowconfig

landing/package.json

lib/.flowconfig

lib/package.json

lib/shared/notif-utils.js

native/.flowconfig

native/calendar/calendar.react.js

native/calendar/entry.react.js

native/flow-typed/npm/@react-navigation/native_v6.x.x.js

native/flow-typed/npm/react-native-reanimated_v2.x.x.js

native/media/file-utils.js

native/navigation/disconnected-bar.react.js

native/navigation/tab-bar.react.js

native/package.json

patches/react-native-firebase+5.6.0.patch

web/.flowconfig

web/calendar/entry.react.js

web/electron.js

web/package.json

web/vector-utils.js

yarn.lock

[native] [10/40] RN 0.70: Flow update
ClosedPublic
Actions

Revision Contents
Changeset List