Page MenuHomePhabricator
Differential D5914

[native] [20/40] RN 0.70: Replace deprecated icons
ClosedPublic
Actions

Authored by ashoat on Dec 18 2022, 7:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 7, 1:15 AM
Unknown Object (File)
Thu, Apr 3, 10:25 PM
Unknown Object (File)
Fri, Mar 28, 8:02 AM
Unknown Object (File)
Tue, Mar 18, 3:27 PM
Unknown Object (File)
Sat, Mar 15, 7:22 AM
Unknown Object (File)
Sat, Mar 15, 7:22 AM
Unknown Object (File)
Sat, Mar 15, 7:18 AM
Unknown Object (File)
Mar 7 2025, 8:33 AM
View All Files
Subscribers
atul

Details

Reviewers
tomek
bartek
Commits
rCOMMf2a5a44c6bf9: [native] [20/40] RN 0.70: Replace deprecated icons
Summary

Flow reported that some icon name were incorrect. I investigated, and sure enough those icon names weren't working. Looks like they were deprecated or something. I replaced them with what I determined was the renamed icons, and in some cases applied small edits to styles to adjust for differences.

Test Plan

Checked out the screens for each of the icons I changed on both iOS and Android

Depends on D5913

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Dec 18 2022, 7:10 PM
Herald added a subscriber: atul. · View Herald TranscriptDec 18 2022, 7:10 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 18 2022, 7:11 PM
Harbormaster failed remote builds in B14243: Diff 19482!
ashoat added a child revision: D5915: [native] [21/40] RN 0.70: Update comm-react-native-codegen.Dec 18 2022, 7:14 PM
ashoat updated this revision to Diff 19504.Dec 18 2022, 8:17 PM

Rebase

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 18 2022, 8:24 PM
Harbormaster failed remote builds in B14265: Diff 19504!
ashoat updated this revision to Diff 19531.Dec 18 2022, 8:30 PM

Rebase

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 18 2022, 8:56 PM
Harbormaster failed remote builds in B14292: Diff 19531!
ashoat updated this revision to Diff 19593.Dec 19 2022, 8:21 AM

Rebase

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 19 2022, 8:35 AM
Harbormaster failed remote builds in B14344: Diff 19593!
ashoat updated this revision to Diff 19626.Dec 19 2022, 8:37 AM

Rebase

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 19 2022, 9:04 AM
Harbormaster failed remote builds in B14377: Diff 19626!
ashoat requested review of this revision.Dec 19 2022, 9:10 AM

Please ignore CI until the end of the stack

ashoat updated this revision to Diff 19699.Dec 19 2022, 12:28 PM

Rebase

Harbormaster failed remote builds in B14444: Diff 19699!Dec 19 2022, 12:34 PM
bartek accepted this revision.Dec 20 2022, 3:15 AM
This revision is now accepted and ready to land.Dec 20 2022, 3:15 AM
tomek accepted this revision.Dec 20 2022, 5:12 AM
ashoat updated this revision to Diff 19757.Dec 20 2022, 6:21 AM

Rebase

Harbormaster failed remote builds in B14500: Diff 19757!Dec 20 2022, 6:28 AM
ashoat updated this revision to Diff 19819.Dec 20 2022, 11:01 AM

Rebase

Harbormaster failed remote builds in B14559: Diff 19819!Dec 20 2022, 11:17 AM
This revision was landed with ongoing or failed builds.Dec 20 2022, 12:01 PM
Closed by commit rCOMMf2a5a44c6bf9: [native] [20/40] RN 0.70: Replace deprecated icons (authored by ashoat). · Explain Why
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMMf2a5a44c6bf9: [native] [20/40] RN 0.70: Replace deprecated icons.

Revision Contents
Changeset List

Diff 19531

View Options

native/chat/chat-thread-list-see-more-sidebars.react.js

Show First 20 Lines • Show All 55 Lines • ▼ Show 20 Lines networks:
- services-net - services-net
build: build:
dockerfile: services/identity/Dockerfile dockerfile: services/identity/Dockerfile
context: ../ context: ../
image: commapp/identity-server:0.1 image: commapp/identity-server:0.1
container_name: identity-server container_name: identity-server
ports: ports:
- "${COMM_SERVICES_PORT_IDENTITY}:50051" - "${COMM_SERVICES_PORT_IDENTITY}:50051"
# localstack
localstack:
image: localstack/localstack
container_name: localstack
hostname: localstack
ports:
- "4566:4566"
environment:
- SERVICES=s3,dynamodb
- DATA_DIR=${TMPDIR}/localstack/data
- HOSTNAME_EXTERNAL=localstack
volumes:
jimUnsubmitted
Not Done
Inline Actions

Why bind mount a temp directory instead of using a data volume? It's just gonna create issues with permissions. Also ${TMPDIR} is not used to refer to a path in both the host and the container which is a bad idea.

jim: Why bind mount a temp directory instead of using a data volume? It's just gonna create issues…
- ${TMPDIR}:/tmp/localstack
networks:
- services-net
View Options

native/chat/message-list-header-title.react.js

Show First 20 Lines • Show All 55 Lines • ▼ Show 20 Lines networks:
- services-net - services-net
build: build:
dockerfile: services/identity/Dockerfile dockerfile: services/identity/Dockerfile
context: ../ context: ../
image: commapp/identity-server:0.1 image: commapp/identity-server:0.1
container_name: identity-server container_name: identity-server
ports: ports:
- "${COMM_SERVICES_PORT_IDENTITY}:50051" - "${COMM_SERVICES_PORT_IDENTITY}:50051"
# localstack
localstack:
image: localstack/localstack
container_name: localstack
hostname: localstack
ports:
- "4566:4566"
environment:
- SERVICES=s3,dynamodb
- DATA_DIR=${TMPDIR}/localstack/data
- HOSTNAME_EXTERNAL=localstack
volumes:
jimUnsubmitted
Not Done
Inline Actions

Why bind mount a temp directory instead of using a data volume? It's just gonna create issues with permissions. Also ${TMPDIR} is not used to refer to a path in both the host and the container which is a bad idea.

jim: Why bind mount a temp directory instead of using a data volume? It's just gonna create issues…
- ${TMPDIR}:/tmp/localstack
networks:
- services-net
View Options

native/chat/settings/thread-settings-list-action.react.js

Show First 20 Lines • Show All 55 Lines • ▼ Show 20 Lines networks:
- services-net - services-net
build: build:
dockerfile: services/identity/Dockerfile dockerfile: services/identity/Dockerfile
context: ../ context: ../
image: commapp/identity-server:0.1 image: commapp/identity-server:0.1
container_name: identity-server container_name: identity-server
ports: ports:
- "${COMM_SERVICES_PORT_IDENTITY}:50051" - "${COMM_SERVICES_PORT_IDENTITY}:50051"
# localstack
localstack:
image: localstack/localstack
container_name: localstack
hostname: localstack
ports:
- "4566:4566"
environment:
- SERVICES=s3,dynamodb
- DATA_DIR=${TMPDIR}/localstack/data
- HOSTNAME_EXTERNAL=localstack
volumes:
jimUnsubmitted
Not Done
Inline Actions

Why bind mount a temp directory instead of using a data volume? It's just gonna create issues with permissions. Also ${TMPDIR} is not used to refer to a path in both the host and the container which is a bad idea.

jim: Why bind mount a temp directory instead of using a data volume? It's just gonna create issues…
- ${TMPDIR}:/tmp/localstack
networks:
- services-net
View Options

native/media/camera-modal.react.js

Show First 20 Lines • Show All 55 Lines • ▼ Show 20 Lines networks:
- services-net - services-net
build: build:
dockerfile: services/identity/Dockerfile dockerfile: services/identity/Dockerfile
context: ../ context: ../
image: commapp/identity-server:0.1 image: commapp/identity-server:0.1
container_name: identity-server container_name: identity-server
ports: ports:
- "${COMM_SERVICES_PORT_IDENTITY}:50051" - "${COMM_SERVICES_PORT_IDENTITY}:50051"
# localstack
localstack:
image: localstack/localstack
container_name: localstack
hostname: localstack
ports:
- "4566:4566"
environment:
- SERVICES=s3,dynamodb
- DATA_DIR=${TMPDIR}/localstack/data
- HOSTNAME_EXTERNAL=localstack
volumes:
jimUnsubmitted
Not Done
Inline Actions

Why bind mount a temp directory instead of using a data volume? It's just gonna create issues with permissions. Also ${TMPDIR} is not used to refer to a path in both the host and the container which is a bad idea.

jim: Why bind mount a temp directory instead of using a data volume? It's just gonna create issues…
- ${TMPDIR}:/tmp/localstack
networks:
- services-net