Paths

Table of Contentst

Differential D5896

[native] [2/40] RN 0.70: Podfile update
ClosedPublic
Actions

Authored by ashoat on Dec 18 2022, 3:21 AM.

Tags

None

Referenced Files

	F32345137: D5896.1765312983.diff
	Mon, Dec 8, 8:43 PM

	F32344720: D5896.1765312808.diff
	Mon, Dec 8, 8:40 PM

Subscribers

Details

Reviewers

tomek
bartek

Commits

rCOMM98231208cd0d: [native] [2/40] RN 0.70: Podfile update

Summary

Changes mostly pulled from React Native Upgrade Helper. Will describe the rest inline.

Depends on D5895

Test Plan

Along with testing pod install, this was tested along with whole stack: test plan

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Dec 18 2022, 3:21 AM

Herald added a subscriber: atul. · View Herald TranscriptDec 18 2022, 3:21 AM

ashoat added inline comments.Dec 18 2022, 3:22 AM

native/ios/Podfile
29	I had to make this change for the app to work. Not sure why `config[:reactNativePath]` wasn't working anymore. Can investigate this more if desired
39	This gets disabled later in the stack, but keeping it the same here for now
47	I had to make this change for `pod install` to work

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 18 2022, 3:24 AM

Harbormaster failed remote builds in B14225: Diff 19459!

ashoat added a child revision: D5897: [native] [3/40] RN 0.70: iOS stuff.Dec 18 2022, 3:26 AM

Please ignore CI until the end of the stack

tomek accepted this revision.Dec 19 2022, 12:33 PM

This revision is now accepted and ready to land.Dec 19 2022, 12:33 PM

bartek accepted this revision.Dec 19 2022, 1:57 PM

Rebase

Harbormaster failed remote builds in B14541: Diff 19801!Dec 20 2022, 7:02 PM

This revision was landed with ongoing or failed builds.Dec 20 2022, 8:00 PM

Closed by commit rCOMM98231208cd0d: [native] [2/40] RN 0.70: Podfile update. · Explain Why

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM98231208cd0d: [native] [2/40] RN 0.70: Podfile update.

Revision Contents
Changeset List

Path

Size

native/

ios/

Comm.xcodeproj/

project.pbxproj

44 lines

40 lines

764 lines

Diff 19459

native/ios/Comm.xcodeproj/project.pbxproj

Loading...

native/ios/Podfile

Loading...

native/ios/Podfile.lock

Loading...