Page MenuHomePhabricator
Differential D5896

[native] [2/40] RN 0.70: Podfile update
ClosedPublic
Actions

Authored by ashoat on Dec 17 2022, 7:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 11, 11:44 PM
Unknown Object (File)
Mon, Nov 11, 9:44 PM
Unknown Object (File)
Sun, Nov 10, 5:55 PM
Unknown Object (File)
Wed, Nov 6, 7:10 PM
Unknown Object (File)
Wed, Nov 6, 6:25 AM
Unknown Object (File)
Wed, Nov 6, 6:25 AM
Unknown Object (File)
Wed, Nov 6, 6:25 AM
Unknown Object (File)
Mon, Nov 4, 8:23 AM
View All Files
Subscribers
atul

Details

Reviewers
tomek
bartek
Commits
rCOMM98231208cd0d: [native] [2/40] RN 0.70: Podfile update
Summary

Changes mostly pulled from React Native Upgrade Helper. Will describe the rest inline.

Depends on D5895

Test Plan

Along with testing pod install, this was tested along with whole stack: test plan

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Dec 17 2022, 7:21 PM
Herald added a subscriber: atul. · View Herald TranscriptDec 17 2022, 7:21 PM
ashoat added inline comments.Dec 17 2022, 7:22 PM
native/ios/Podfile
29

I had to make this change for the app to work. Not sure why config[:reactNativePath] wasn't working anymore. Can investigate this more if desired

39

This gets disabled later in the stack, but keeping it the same here for now

47

I had to make this change for pod install to work

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 17 2022, 7:24 PM
Harbormaster failed remote builds in B14225: Diff 19459!
ashoat added a child revision: D5897: [native] [3/40] RN 0.70: iOS stuff.Dec 17 2022, 7:26 PM
ashoat requested review of this revision.Dec 17 2022, 8:07 PM

Please ignore CI until the end of the stack

tomek accepted this revision.Dec 19 2022, 4:33 AM
This revision is now accepted and ready to land.Dec 19 2022, 4:33 AM
bartek accepted this revision.Dec 19 2022, 5:57 AM
ashoat updated this revision to Diff 19801.Dec 20 2022, 10:59 AM

Rebase

Harbormaster failed remote builds in B14541: Diff 19801!Dec 20 2022, 11:02 AM
This revision was landed with ongoing or failed builds.Dec 20 2022, 12:00 PM
Closed by commit rCOMM98231208cd0d: [native] [2/40] RN 0.70: Podfile update (authored by ashoat). · Explain Why
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM98231208cd0d: [native] [2/40] RN 0.70: Podfile update.

Revision Contents
Changeset List

PathSize
native/
ios/
Comm.xcodeproj/
44 lines
40 lines
764 lines

Diff 19459

View Options

native/ios/Comm.xcodeproj/project.pbxproj

Loading...
View Options

native/ios/Podfile

Loading...
View Options

native/ios/Podfile.lock

Loading...