HomePhabricator
Diffusion Comm 1d4de8a87620

[web] [fix] ENG-766 sidebar sidebar height chopped off + font size

Tags
None
Referenced Files
F23020: Image 2022-03-16 at 2.47.05 PM.jpg
Apr 19 2022, 9:49 AM
F23021: Image 2022-03-16 at 2.47.30 PM.jpg
Apr 19 2022, 9:49 AM
F38781: Image 2022-04-13 at 2.21.43 PM.jpg
Apr 19 2022, 9:49 AM
Subscribers

Description

[web] [fix] ENG-766 sidebar sidebar height chopped off + font size

Summary:
Fix sidebar height chopping off per the issue. https://linear.app/comm/issue/ENG-766/sidebar-height-was-chopped-in-order-to-have-a-continuous-line
https://linear.app/comm/issue/ENG-766/sidebar-height-was-chopped-in-order-to-have-a-continuous-line

https://phabricator.ashoat.com/file/data/5fdirsmbi6qpkmd3im55/PHID-FILE-nvwfipkwd6aamahkzjdr/Image_2022-03-18_at_10.08.03_AM.jpg
Note: This diff introduces a regression in sidebars where the arrows aren't continuous. This issue will be fixed in a future diff in the stack.

Image 2022-03-16 at 2.47.05 PM.jpg (766×1 px, 68 KB)

Image 2022-03-16 at 2.47.30 PM.jpg (690×1 px, 85 KB)

Follow up on initial post:

Image 2022-04-13 at 2.21.43 PM.jpg (1×816 px, 75 KB)

Is the updated sidebar without chopped height. (this is a screenshot of the end of the stack). You'll notice an ever so thinner extender in the second thread. That's something I'll address moving forward either:

I know it's a subtle visual bug, but it will unblock my stack, and straighten out a lot of issues with the chat thread list items.

Test Plan: check figma, make sure it looks okay: https://www.figma.com/file/a1nkbWgbgjRlrOY9LVurTz/Comm-%2F-Desktop-app?node-id=1170%3A79583

Reviewers: atul, palys-swm, def-au1t

Reviewed By: palys-swm

Subscribers: ashoat, palys-swm, Adrian, karol-bisztyga

Differential Revision: https://phabricator.ashoat.com/D3440

Details

Provenance
benschacAuthored on Apr 19 2022, 9:47 AM
Reviewer
tomek
Differential Revision
D3440: [web] [fix] ENG-766 sidebar sidebar height chopped off + font size
Parents
rCOMMd77f80b11afb: [web] [fix] [ENG-731] update thread selected state text
Branches
Unknown
Tags
Unknown