HomePhabricator
Diffusion Comm 1dd97d64658b

[web] removed pagination logic from thread picker

Description

[web] removed pagination logic from thread picker

Summary:
removed pagination logic as discussed in Linear. Now if there are more than 5 threads, they will all just render instead of being paginated

Next steps:

  1. Implement the search logic

Linear task: ENG-1847

Test Plan:
Please view the attached screenshots to see the before and after of the changes I made:

Before:

Screen Shot 2022-09-26 at 1.47.07 PM.png (462×556 px, 42 KB)

6 threads would cause the picker to paginate and show the first 5 threds

After:

Screen Shot 2022-09-26 at 1.59.21 PM.png (412×454 px, 39 KB)

Now all 6 threads are shown

Reviewers: atul, rohan, abosh

Reviewed By: atul, rohan

Subscribers: ashoat, tomek, atul, abosh

Differential Revision: https://phab.comm.dev/D5230

Details

Provenance
ginsuAuthored on Sep 26 2022, 10:58 AM
Reviewer
atul
Differential Revision
D5230: [web] removed pagination logic from thread picker
Parents
rCOMM84dbf3bb62c8: [lib] Update `staff.js` (again)
Branches
Unknown
Tags
Unknown