HomePhabricator
Diffusion Comm 2b24a6f0d704

[web] Introduce `AllNotifsIllustration` component to replace S3-hosted asset

Description

[web] Introduce AllNotifsIllustration component to replace S3-hosted asset

Summary:
Context: https://linear.app/comm/issue/ENG-1584/[web]-replace-s3-svg-urls-with-svgr-generated-react-components

We previously were fetching all-notifs.svg from S3. It took a second for the SVG to download, which led to the page reflowing. We got around the reflowing issue by explicitly stating the height/width of every SVG asset so there was some "placeholder space" left for the asset to fill once it loaded. This led to an expensive process when adding SVG assets to web.

Instead, we can convert the SVG into a React component using SVGR (https://react-svgr.com/playground/) and include it in the repo. This also lets us avoid fetching the asset once the app has loaded.


Depends on D4785

Test Plan:
Things continue to look as expected.

Before:

Screen Shot 2022-08-09 at 3.00.54 PM.png (1×868 px, 97 KB)

After:

Screen Shot 2022-08-09 at 2.59.13 PM.png (1×868 px, 126 KB)

Reviewers: varun, abosh, tomek, jacek

Reviewed By: varun, abosh

Subscribers: ashoat, adrian

Differential Revision: https://phab.comm.dev/D4786