HomePhabricator
Diffusion Comm 2d116af68312

[web] Move styles in `style.css` used by `ThreadSettingsModal` to `thread…

Tags
None
Referenced Files
F28043: after.png
Apr 4 2022, 2:18 PM
F28042: before.png
Apr 4 2022, 2:18 PM
Subscribers
None

Description

[web] Move styles in style.css used by ThreadSettingsModal to thread-settings-modal.css

Summary:
Move the styles used by ThreadSettingsModal in style.css to thread-settings-moda.css (if they aren't used elsewhere in repo, in which case they were copied) and "consume" thread-settings-modal.css in ThreadSettingsModal.

This already gets us closer to where we want to be.

Before:

before.png (574×1 px, 54 KB)

After:

after.png (540×1 px, 51 KB)

Note: The current-tab, delete-tab and modal-radio selectors are neither in style.css nor in user-settings-modal.css (the file that thread-settings-modal.css was copied from). Will handle styling of these selectors in later diff.

Next diffs:

  1. Remove extraneous selectors from thread-settings-modal.css that aren't used in the ThreadSettingsModal component.
  2. Fill in styles that are "used" by ThreadSettingsModal that don't actually exist anywhere in the repo (eg current-tab). Probably by looking through the git history to see what current-tab used to be.
  3. Style the ThreadSettingsModal component so it looks decent.

Depends on D3589

Test Plan: NA, looks closer to what it used to looks like.

Reviewers: palys-swm, benschac, def-au1t, ashoat

Reviewed By: ashoat

Subscribers: Adrian, karol-bisztyga, yayabosh

Differential Revision: https://phabricator.ashoat.com/D3591