HomePhabricator
Diffusion Comm 3038ee4e7aeb

[native] update baseNoDataAfterPolicyAcknowledgmentSelector check

Description

[native] update baseNoDataAfterPolicyAcknowledgmentSelector check

Summary:
Discovered while looking at ENG-5883.

This selector was not sufficiently specific; we should not only verify that all policies are accepted but also check if any policy has been accepted. The previous version could inaccurately return a truthy value in cases other than the absence of data following policy acknowledgment.

Note: In most standard use cases, userPolicies is empty. It's only populated when policies need to be accepted with falsy flags, and right after acknowledgment, to handle cases such as this one.

Test Plan:

  1. Test policies mechanism
  2. Test policies with socket issues
  3. Make sure in other cases this condition is falsy

Reviewers: tomek, michal, inka

Reviewed By: tomek

Subscribers: ashoat

Differential Revision: https://phab.comm.dev/D9965

Details

Provenance
kamilAuthored on Nov 23 2023, 3:42 PM
Reviewer
tomek
Differential Revision
D9965: [native] update baseNoDataAfterPolicyAcknowledgmentSelector check
Parents
rCOMM19641867cd73: Revert "[native] Temporary changes for staff release"
Branches
Unknown
Tags
Unknown