HomePhabricator
Diffusion Comm 336f32113f4d

[web] [fix] add icons with default paddings

Tags
None
Referenced Files
F16681: Image 2022-02-28 at 12.38.50 PM.jpg
Mar 9 2022, 10:38 AM
F16682: Image 2022-02-28 at 12.43.02 PM.jpg
Mar 9 2022, 10:38 AM
Subscribers
None

Description

[web] [fix] add icons with default paddings

Summary:
Re-import icons with default paddings from icon pack.

Imported Icons

Image 2022-02-28 at 12.43.02 PM.jpg (1×3 px, 395 KB)

The diff is a little bigger because I had to delete all of the old icons and re-import but they got out of order. If it's a big deal I can go back and order the icons to their previous state.

Note: All of the icons will appear smaller now that paddings are added back to the fonts. Looking at the UI and figma they're now (almost) the correct size. The only exception that I found so far of icons that need to be updated in a follow-up diff are in the input (picture and send icons) which are linked in this stack. Additional icon size adjustments are addressed in following diffs in this stack.

Test Plan:
inspect icons, they should have padding

Image 2022-02-28 at 12.38.50 PM.jpg (242×356 px, 10 KB)

This diff doesn't update layout or fix any sizing issues with imported icons. All it's doing is replacing the old icons without paddings with the icons that do have paddings.

I grepped the repo and updated every icon in the following diffs to address the updated icons with paddings.

Just confirming here all of the files that have <SWMansionIcon /> component. They have either been updated or currently match the design.

calendar.js: N/A there wasn't design for this page. No updates.
chat-input-bar: plus, send and image icons have been updated both in size and layout.
chat-thread-ancestors: cloud, and chevron-right icons have been updated to correct sizes
chat-thread-list-item-menu: menu-vertical is the correct size per figma designs.
chat-thread-list-item: is the correct size
chat-thread-tab: icons are updated to 24px, the correct size.
message-action-buttons: is correct size 18px.
message-reply-button: is correct size 18px.
sidebar-item: right angle arrow isn't a SWM icon (the long sidebar arrow), doesn't need to be updated.
thread-menu: menu icon has been updated to the correct size and button element padding has been removed.

Reviewers: atul, palys-swm, ashoat

Reviewed By: atul, ashoat

Subscribers: ashoat, Adrian, karol-bisztyga

Differential Revision: https://phabricator.ashoat.com/D3299

Details

Provenance
benschacAuthored on Mar 9 2022, 10:35 AM
Reviewer
atul
Differential Revision
D3299: [web] [fix] add icons with default paddings
Parents
rCOMMf855c95576d1: [web] [fix] updated icons component
Branches
Unknown
Tags
Unknown