HomePhabricator
Diffusion Comm 36084420e00c

rename `source` to `logInActionSource`

Description

rename source to logInActionSource

Summary:
Rename source (connected with session context) to logInActionSource to avoid redacting it from reports.

_task: ENG-2131

Test Plan:

  1. Typecheck
  2. Check if logInActionSource is properly passed to keyserver
  3. Trrigger one of logInActionSource actions and trigger app crash in dev tools, check if logInActionSource is present in the action payload in the latest crash report from the database

example:

{
  "type": "SET_NEW_SESSION",
  "payload": {
    "sessionChange": {
      "cookieInvalidated": false,
      "currentUserInfo": {
        "id": "[redacted-3087747816]",
        "username": "[redacted-642983437]"
      }
    },
    "preRequestUserState": null,
    "logInActionSource": "SOCKET_AUTH_ERROR_RESOLUTION_ATTEMPT"
  }
},
  1. Check if existing clients can log in (as described here: https://phab.comm.dev/D5517#163191)

Reviewers: tomek, atul, ashoat

Reviewed By: tomek, ashoat

Subscribers: ashoat, atul, abosh

Differential Revision: https://phab.comm.dev/D5517

Details

Provenance
kamilAuthored on Nov 2 2022, 5:26 AM
Reviewer
tomek
Differential Revision
D5517: rename `source` to `logInActionSource`
Parents
rCOMM6e570829c37c: [sql/keyserver] added multipleStatements to fix fatal error
Branches
Unknown
Tags
Unknown