HomePhabricator
Diffusion Comm 3e1cc43ba3b1

[native] introduced reactions to chat item height measurer

Description

[native] introduced reactions to chat item height measurer

Summary:
introduced reactions to chat item height measurer. This is necessary to because in native/chat/message-list-container we measure the messages first and then pass the message list data with heights down to MessageList which will eventually then be used by InlineSidebar


Depends on D5811
Linear Task: ENG-2408

Test Plan:
Will be doing more tests in subsequent diffs. Ran mobile/web app locally and nothing crashes. I also was able to get to the point where I could send and reaction and it would render on my local stack (see demo video below)

Also, before these changes I was getting this error message in my logs telling me that the height was incorrect; however, after these changes the error message went away showing that InlineSidebar was taken into consideration

Screenshot 2022-12-05 at 9.34.38 PM.png (1×3 px, 939 KB)

Reviewers: atul, tomek, rohan, ashoat

Reviewed By: atul, tomek, ashoat

Subscribers: ashoat, tomek, atul

Differential Revision: https://phab.comm.dev/D5812

Details

Provenance
ginsuAuthored on Dec 5 2022, 3:01 PM
Reviewer
atul
Differential Revision
D5812: [native] introduced reactions to chat item height measurer
Parents
rCOMMe9605efbb4b7: [lib] introduced reactions field to chatMessageItems
Branches
Unknown
Tags
Unknown