HomePhabricator
Diffusion Comm 3eae57836282

[native] Add memoization to `SidebarItem`

Description

[native] Add memoization to SidebarItem

Summary: Call to shortAbsoluteDate in particular takes surprisingly long (like 5ms each time and it's re-rendering like 5 times and there are 5 instances so 5*5*5ms = 125ms total when doing the "navigate to thread w/ varun scenario").

Test Plan: Continues to work/appear as before.

Reviewers: ginsu, tomek, rohan

Reviewed By: ginsu

Subscribers: ashoat

Differential Revision: https://phab.comm.dev/D9099

Details

Provenance
atulAuthored on Sep 7 2023, 2:03 PM
Reviewer
ginsu
Differential Revision
D9099: [native] Add memoization to `SidebarItem`
Parents
rCOMMcf96d9a28808: Revert "Temporary changes for staff release"
Branches
Unknown
Tags
Unknown