HomePhabricator
Diffusion Comm 4310f85f4e96

Merge SensitiveDataHandler functionality into SQLiteContextProvider

Description

Merge SensitiveDataHandler functionality into SQLiteContextProvider

Summary: This differential merges SensitiveDataHandler functionality into SQLiteContextProvider. There is a race condition between those two components which might lead to hard to debug issue. Therefore in this differential we make sure that functionalities privided by those two components are always executed in deterministic order.

Test Plan: Test plan for this differential should include test plans for those two differentials: https://phab.comm.dev/D4730, https://phab.comm.dev/D5444 since SensitiveDataHandler functionality should remain. Additionally we should temporarily add logging inside handleSensitiveData and before SQLiteContextProvider queries SQLite and updates redux. We should ensure the order of logs is deterministic on every app run.

Reviewers: tomek, atul, ashoat

Reviewed By: tomek, atul, ashoat

Subscribers: ashoat, abosh

Differential Revision: https://phab.comm.dev/D5581

Details

Provenance
marcinAuthored on Nov 9 2022, 4:44 AM
Reviewer
tomek
Differential Revision
D5581: Merge SensitiveDataHandler functionality into SQLiteContextProvider
Parents
rCOMM2c0334fd697e: [native] Move React Native patchfile
Branches
Unknown
Tags
Unknown