HomePhabricator
Diffusion Comm 444097a49ec7

[server] Make time filter check less brittle in fetchMessageInfos

Description

[server] Make time filter check less brittle in fetchMessageInfos

Summary: This diff is a follow-up to @palys-swm's comment in D3410.

Test Plan:

  1. I tested different values of defaultMaxMessageAge such that some threads would return fewer than defaultNumberPerThread, and some threads would return 0
  2. I tested threads that needed a fetchMostRecentMessages, and threads that needed multiple fetchMessagesBeforeCursor to get to the start
  3. I made sure all threads loaded all the way to the start of a thread if I kept scrolling

Reviewers: palys-swm, atul

Reviewed By: palys-swm

Subscribers: Adrian, karol-bisztyga, benschac, palys-swm

Differential Revision: https://phabricator.ashoat.com/D3426

Details

Provenance
ashoatAuthored on Mar 14 2022, 12:47 PM
Reviewer
tomek
Differential Revision
D3426: [server] Make time filter check less brittle in fetchMessageInfos
Parents
rCOMM6f7a084f3615: [misc] Introduce `.editorconfig`
Branches
Unknown
Tags
Unknown