HomePhabricator
Diffusion Comm 45e12d147022

Unpack draft object to key and text in commCoreModule updateDraft method…

Description

Unpack draft object to key and text in commCoreModule updateDraft method signature

Summary: This differential addresses the following Linear urgent issue: https://linear.app/comm/issue/ENG-2374/jsi-codegen-broken-by-new-drafts-types. It is done by removing draft as argument type from updateDraft method and passing key and text directly.

Test Plan: 1. cd native && yarn codegen-jsi MUST work. 2. Launch flipper, type drafts, close the app. Open again and ensure that typped drafts are in the payload of setClientDBStore action. This way we simply ensure that modifying updateDraft on the C++ side didn't break draft-persistence functionality.

Reviewers: tomek, atul, jon, ashoat

Reviewed By: ashoat

Subscribers: ashoat

Differential Revision: https://phab.comm.dev/D5767

Details

Provenance
marcinAuthored on Nov 30 2022, 4:33 AM
Reviewer
ashoat
Differential Revision
D5767: Unpack draft object to key and text in commCoreModule updateDraft method signature
Parents
rCOMMd7a265f1e264: Revert "Temporary changes for staff release"
Branches
Unknown
Tags
Unknown