HomePhabricator
Diffusion Comm 469c8bf3efd8

[native] Fix inline sidebar background color

Description

[native] Fix inline sidebar background color

Summary:
Fixes ENG-1954.
It turns out that sidebar wrapper/holder (with 100% width) had background color set to black. And because it has border radius set, the top-left corner looked OK (or the top-right in case when viewer is author of the message).

Fixed it by removing the background color and making the view opaque.

Test Plan:
Tested in iOS simulator, used RN Element Inspector.

Temporarily set the background to green and disabled cornerRadius (1st screen) to show the element. The last screen shows final effect

Simulator Screen Shot - iPhone 14 Pro - 2022-10-10 at 12.24.06.png (2×1 px, 317 KB)

Simulator Screen Shot - iPhone 14 Pro - 2022-10-10 at 12.27.15.png (2×1 px, 301 KB)

Simulator Screen Shot - iPhone 14 Pro - 2022-10-10 at 12.24.33.png (2×1 px, 316 KB)

Reviewers: ashoat, tomek, atul

Reviewed By: atul

Subscribers: atul, abosh

Differential Revision: https://phab.comm.dev/D5325

Details

Provenance
bartekAuthored on Oct 10 2022, 3:27 AM
Reviewer
atul
Differential Revision
D5325: [native] Fix inline sidebar background color
Parents
rCOMM1d9460715e6f: [services] Use ensure! macro where possible
Branches
Unknown
Tags
Unknown