HomePhabricator
Diffusion Comm 4c5277d8ef9c

[keyserver] Stop returning set of `deviceToken`s in `rescindPushNotifs(...)`

Tags
None
Referenced Files
F232111: e52dda.png
Nov 10 2022, 1:53 PM
File Not Attached
F232110: 797a5e.png
Nov 10 2022, 1:53 PM
File Not Attached
F232109: 2cb525.png
Nov 10 2022, 1:53 PM
File Not Attached
F232108: 2c15a2.png
Nov 10 2022, 1:53 PM
File Not Attached
Subscribers
None

Description

[keyserver] Stop returning set of deviceTokens in rescindPushNotifs(...)

Summary:
We were previously using the set of deviceTokens returned by rescindPushNotifs(...) in rescindAndUpdateBadgeCounts to skip updateBadgeCount(...) for devices that had notifications rescinded. See D5606 for context.

Basically, we don't need the set of deviceTokens in rescindAndUpdateBadgeCounts and it isn't used anywhere else so it can be removed.


Depends on D5606

Test Plan:
Looked at other usages of rescindPushNotifs(...) and the return value was never used:

2c15a2.png (246×1 px, 77 KB)

2cb525.png (174×930 px, 38 KB)

797a5e.png (728×1 px, 162 KB)

e52dda.png (700×1 px, 167 KB)

Reviewers: tomek, marcin, varun, ginsu, rohan, ashoat

Reviewed By: ashoat

Subscribers: ashoat, abosh

Differential Revision: https://phab.comm.dev/D5607

Details