HomePhabricator
Diffusion Comm 4ea4695b57fa

[landing] Reset messageSentRef.current on error

Description

[landing] Reset messageSentRef.current on error

Summary:
Some folks reported issues with this flow earlier today. The reports came in within a single hour period, so I suspect transient network issues.

I spent some time looking at the code here that handles talking to the relay server, and one potential risk here is that if there's an error after the URL redirect occurs, we'll never retry that step. Probably a good idea to reset this, so that if a retry is necessitated after a URL redirect, we can retry the process from the start (including redoing the URL redirect).

Depends on D13580

Test Plan:
I tested this one the same as the previous two, which is to say I followed this doc on Notion for both physical iOS and Android devices

Ideally I'd test the isError state here, but it would be really expensive since I'd need to patch @farcaster/auth-kit to force isError, but that package distributes transpiled source

Reviewers: varun, will

Subscribers: tomek

Differential Revision: https://phab.comm.dev/D13581

Details

Provenance
ashoatAuthored on Oct 2 2024, 8:31 PM
Differential Revision
D13581: [landing] Reset messageSentRef.current on error
Parents
rCOMM48a911cb0b28: [landing] Set redirectUrl so that Warpcast redirects back to Comm
Branches
Unknown
Tags
Unknown