Page MenuHomePhabricator

[landing] Reset messageSentRef.current on error
ClosedPublic

Authored by ashoat on Oct 2 2024, 8:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 18, 8:38 AM
Unknown Object (File)
Wed, Dec 18, 8:38 AM
Unknown Object (File)
Wed, Dec 18, 8:38 AM
Unknown Object (File)
Wed, Dec 18, 8:37 AM
Unknown Object (File)
Thu, Dec 5, 12:12 AM
Unknown Object (File)
Wed, Dec 4, 5:47 PM
Unknown Object (File)
Wed, Dec 4, 10:41 AM
Unknown Object (File)
Mon, Dec 2, 6:45 AM
Subscribers

Details

Summary

Some folks reported issues with this flow earlier today. The reports came in within a single hour period, so I suspect transient network issues.

I spent some time looking at the code here that handles talking to the relay server, and one potential risk here is that if there's an error after the URL redirect occurs, we'll never retry that step. Probably a good idea to reset this, so that if a retry is necessitated after a URL redirect, we can retry the process from the start (including redoing the URL redirect).

Depends on D13580

Test Plan

I tested this one the same as the previous two, which is to say I followed this doc on Notion for both physical iOS and Android devices

Ideally I'd test the isError state here, but it would be really expensive since I'd need to patch @farcaster/auth-kit to force isError, but that package distributes transpiled source

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Draft.Oct 2 2024, 8:43 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.