HomePhabricator
Diffusion Comm 51ce1fc711c8

[native] Add a header componnent with a search bar

Description

[native] Add a header componnent with a search bar

Summary:
issue: https://linear.app/comm/issue/ENG-3405/create-a-header-with-the-search-input-field
This will be used in the message search screen. Some design changes were discussed by me and Ted, and noted on Linear.

iOS:

Screenshot 2023-05-10 at 14.51.58.png (1×684 px, 289 KB)

Android:
Screenshot_2023-05-10-14-49-46-47_bc14914796be02770da2fb3baf3b2995.jpg (2×1 px, 86 KB)

The search button:
Android:

android-search-button.jpg (2×1 px, 198 KB)

iOS (my simulator for some reason refuses to show me the keyboard in english, but "szukaj" is "search" in polish):

Screenshot 2023-05-10 at 15.23.30.png (1×684 px, 337 KB)

Test Plan: Tested with next diffs - tested that the query from the search context is set when the "enter" is pressed, and is not being set on every character change. Tested that the cancel button appears only when the input is not empty. Tested that pressing the cancel button clears the query and the input.

Reviewers: kuba, kamil, bartek, ashoat

Reviewed By: ashoat

Subscribers: ted, ashoat, tomek, atul

Differential Revision: https://phab.comm.dev/D7740

Details

Provenance
InkaSokolowskaAuthored on May 16 2023, 1:31 AM
Reviewer
ashoat
Differential Revision
D7740: [native] Add a header componnent with a search bar
Parents
rCOMM1d14e082facb: [native] Add message search context
Branches
Unknown
Tags
Unknown