HomePhabricator
Diffusion Comm 558d73e620ad

[native] Update existing checks on isDefault in role-panel-entry.react.js

Description

[native] Update existing checks on isDefault in role-panel-entry.react.js

Summary:
We now want to make sure that we get rid of checks on role.isDefault and replace them with checks on role.specialRole:

  • For default roles, this is `role.specialRole === ${specialRoles.DEFAULT_ROLE}
  • For admin roles, this is `role.specialRole === ${specialRoles.ADMIN_ROLE}

Part of ENG-5993

This diff handles role-panel-entry.react.js

Depends on D10117

Test Plan: Confirmed the use of roleIsDefaultRole had no change on the results in the code

Reviewers: ginsu, tomek, rohan

Reviewed By: tomek

Subscribers: ashoat

Differential Revision: https://phab.comm.dev/D10118

Details

Provenance
atulAuthored on Feb 22 2024, 2:06 PM
Reviewer
tomek
Differential Revision
D10118: [native] Update existing checks on isDefault in role-panel-entry.react.js
Parents
rCOMM277f0ba1557f: [lib] Update existing checks on isDefault in thread-utils.js
Branches
Unknown
Tags
Unknown