HomePhabricator
Diffusion Comm 5682f3ca2b94

[native] Exclude `permission.AD_ID` to unblock Android release

Description

[native] Exclude permission.AD_ID to unblock Android release

Summary:
Since we've bumped up to API level 33 since last release we need to be explicit about including/excluding permission.AD_ID permission.

The play-services-measurement dependency (~2019 release) requests the permission.AD_ID which gets merged into the manifest generated during build that we submit to Play Store console.

This permission is only necessary if we need to access the advertising ID of the device (which we don't), and can safely be removed.

Here's the relevant snippet from the docs explaining how to prevent the AD_ID permission from being merged:

bc80bd.png (332×1 px, 66 KB)

https://developers.google.com/android/reference/com/google/android/gms/ads/identifier/AdvertisingIdClient.Info#getId()

Test Plan: Submit another release and see what happens... I guess I could also make a release locally and check the merged manifest?

Reviewers: ashoat, ginsu, bartek, marcin

Reviewed By: ginsu

Subscribers: tomek

Differential Revision: https://phab.comm.dev/D7358

Details

Provenance
atulAuthored on Apr 7 2023, 2:02 PM
Reviewer
ginsu
Differential Revision
D7358: [native] Exclude `permission.AD_ID` to unblock Android release
Parents
rCOMM68bbaa297a06: [Identity] Handle key payload
Branches
Unknown
Tags
Unknown