HomePhabricator
Diffusion Comm 578d87f96f4f

[services][backup] PullBackup - fix tracing span

Description

[services][backup] PullBackup - fix tracing span

Summary:
Logging in async_stream wasn't displaying log spans correctly, this diff fixes that.
I needed to introduce a new dependency tracing-futures (official package from tracing vendor) because the core tracing::Instrumented<T> doesn't implement Stream<T>. With this dependency, we can use <impl Stream>::instrument() and <impl Stream>::in_current_span() which are required to correctly trace streaming logs.

Depends on D6246

Question: Should we display user_id in logs? Or is it sensitive data?

Test Plan:
Ran integration tests and ensured logs are displayed correctly

Screenshot 2023-01-11 at 23.46.17.png (534×3 px, 438 KB)

Reviewers: ashoat, varun, jon, michal

Reviewed By: jon

Subscribers: ashoat, tomek, atul

Differential Revision: https://phab.comm.dev/D6247

Details

Provenance
bartekAuthored on Jan 11 2023, 2:47 PM
Reviewer
jon
Differential Revision
D6247: [services][backup] PullBackup - fix tracing span
Parents
rCOMM357c69fe954e: [services][backup] PullBackup 5/5 - blob download stream
Branches
Unknown
Tags
Unknown