HomePhabricator
Diffusion Comm 58265a727b6c

[web] Introduce minimally viable `ThreadSettingsDeleteTab` component

Description

[web] Introduce minimally viable ThreadSettingsDeleteTab component

Summary:
In an effort to make ThreadSettingsModal easier to work with, we're pulling general, privacy, and delete tabs out into their own separate components.

This diff does that for ThreadSettingsDeleteTab, but in a limited way. We're basically moving over the mainContent JSX markup and prop drilling the state that's still held by ThreadSettingsModal.

Once we've extracted the JSX markup for general, privacy, and delete.. and prop drilled as necessary to keep things working as they did before: we're going to push down the state and functionality into the smaller "tab" components so things are properly encapsulated.

And once that's done, we should be able to turn ThreadSettingsModal into a functional component.. and refactor ThreadSettingsModal using @def-au1t's TabsContainer and TabsItem components.


Depends on D3717

Test Plan: This diff should be a noop. Did a close reading and I'm confident I didn't change any of the logic. Looks as expected:

Reviewers: def-au1t, palys-swm

Reviewed By: palys-swm

Subscribers: ashoat, Adrian, karol-bisztyga, benschac, yayabosh, def-au1t

Differential Revision: https://phabricator.ashoat.com/D3718

Details

Provenance
atulAuthored on Apr 12 2022, 9:08 PM
Reviewer
tomek
Differential Revision
D3718: [web] Introduce minimally viable `ThreadSettingsDeleteTab` component
Parents
rCOMM25f459ea2d6f: [web] Use relationship callback on friend list
Branches
Unknown
Tags
Unknown