HomePhabricator
Diffusion Comm 5a05189c61df

[lib] Fix sidebar source clustering bug

Description

[lib] Fix sidebar source clustering bug

Summary: To reproduce the bug, create sidebar source message which references some message from at least 5 mins ago and another message, younger than sidebar source. Open a thread and notice that the messages were displayed as one cluster with the date of initial message, even though younger message should not be included.

Test Plan: Use reproduction steps and notice that the messages are displayed as two separate clusters.

Reviewers: ashoat

Reviewed By: ashoat

Subscribers: KatPo, zrebcu411, Adrian, atul, subnub

Differential Revision: https://phabricator.ashoat.com/D605

Details

Provenance
tomekAuthored on Jan 14 2021, 6:41 AM
Reviewer
ashoat
Differential Revision
Restricted Differential Revision
Parents
rCOMMc52234e0f99c: [lib] Use more precise types instead of invariant in newThreadRobotext
Branches
Unknown
Tags
Unknown

Event Timeline