HomePhabricator
Diffusion Comm 5db2595aa341

[web] Use new handlers in communnity drawer

Description

[web] Use new handlers in communnity drawer

Summary:
issue: https://linear.app/comm/issue/ENG-3176/make-pressing-a-drawer-item-in-chat-tab-filter-available-chats
Using in CommunityDrawerItem and CommunityDrawerItemCommunity handler implemented im previous diffs. This allows to entierly remove CommunityDrawerItemChat component, as it's only function
is now supplied by the handlers.

Test Plan:
Run web app, checked that pressing drawer items results in:

  • navigating to the corresponding chat, changing the list of availabe chats in ChatThreadList, and expanding the community, for community items in the Chat tab
  • navigating to the corresponging chat, for non-community items in the Chat tab
  • changing the list of available filters in the Calendar tab

some corner cases:

  • If the user is in a subchannel, and presses on the community, we only navigate to that community chat, since I feel it would be weird for that community to collapse in this case
  • If user is in the community chat and presses on that community, the community collapses, and the list of chats gets unfiltered (the filter is cleared)

Reviewers: kamil, tomek, michal

Reviewed By: tomek

Subscribers: ashoat, atul

Differential Revision: https://phab.comm.dev/D6976

Details

Provenance
InkaSokolowskaAuthored on May 23 2023, 12:47 AM
Reviewer
tomek
Differential Revision
D6976: [web] Use new handlers in communnity drawer
Parents
rCOMMc55146e4cd2f: [web] Add expanded and toggleExpanded to CommunityDrawerItemHandler type
Branches
Unknown
Tags
Unknown