Page MenuHomePhabricator

[web] Use new handlers in communnity drawer
ClosedPublic

Authored by inka on Mar 7 2023, 3:55 AM.
Tags
None
Referenced Files
F3231024: D6976.id26820.diff
Tue, Nov 12, 9:57 AM
F3230831: D6976.id26820.diff
Tue, Nov 12, 9:21 AM
Unknown Object (File)
Fri, Nov 8, 2:39 AM
Unknown Object (File)
Fri, Nov 1, 5:34 AM
Unknown Object (File)
Mon, Oct 21, 3:57 PM
Unknown Object (File)
Mon, Oct 21, 3:57 PM
Unknown Object (File)
Sun, Oct 20, 8:32 PM
Unknown Object (File)
Sun, Oct 20, 8:32 PM
Subscribers

Details

Summary

issue: https://linear.app/comm/issue/ENG-3176/make-pressing-a-drawer-item-in-chat-tab-filter-available-chats
Using in CommunityDrawerItem and CommunityDrawerItemCommunity handler implemented im previous diffs. This allows to entierly remove CommunityDrawerItemChat component, as it's only function
is now supplied by the handlers.

Test Plan

Run web app, checked that pressing drawer items results in:

  • navigating to the corresponding chat, changing the list of availabe chats in ChatThreadList, and expanding the community, for community items in the Chat tab
  • navigating to the corresponging chat, for non-community items in the Chat tab
  • changing the list of available filters in the Calendar tab

some corner cases:

  • If the user is in a subchannel, and presses on the community, we only navigate to that community chat, since I feel it would be weird for that community to collapse in this case
  • If user is in the community chat and presses on that community, the community collapses, and the list of chats gets unfiltered (the filter is cleared)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inka requested review of this revision.Mar 7 2023, 4:10 AM
This revision is now accepted and ready to land.Mar 24 2023, 11:27 AM
web/sidebar/community-drawer-item-community.react.js
27–28 ↗(On Diff #24791)

I assume this doesn't work for some reason?

web/sidebar/community-drawer-item-community.react.js
28 ↗(On Diff #26768)

The point of my suggestion to remove the event parameter was so you could delete this eslint-disable line. Is that not possible for some reason?

web/sidebar/community-drawer-item-community.react.js
28 ↗(On Diff #26768)

Ohh, right, sorry. This is not needed

Remove eslint-disable-next-line

web/sidebar/community-drawer-item.react.js
36–37 ↗(On Diff #26808)

Same thing here?

Remove eslint-disable-next-line