In revious diff (D6968) I added to redux state information about the community selected in the Chat tab. This diff adds logic that handles that filed in the reducer, and actions that can be
performed on it. we need to be albe to set the id, and clear it.
issue: https://linear.app/comm/issue/ENG-3176/make-pressing-a-drawer-item-in-chat-tab-filter-available-chats
Details
Details
Dispatched the new actions programatically, and checked that the redux state changes as planned.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| web/redux/redux-setup.js | ||
|---|---|---|
| 201 ↗ | (On Diff #23482) | Maybe it's high time to create a separate reducer for picking communities, don't you think? It'll make this reducer more readable and logically separate this and other stuff like consts from action-types.js? |
| web/redux/redux-setup.js | ||
|---|---|---|
| 201 ↗ | (On Diff #23482) | I agree, we should avoid putting complex reducer functionality in the main file... can you create a new diff (above this one in the stack) that moves the existing functionality to a new file in web/redux/, and then update this diff so that it's updating that file? |