Page MenuHomePhabricator

[web] Add expanded and toggleExpanded to CommunityDrawerItemHandler type
Needs ReviewPublic

Authored by inka on Tue, Mar 7, 3:51 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 22, 5:14 AM
Unknown Object (File)
Tue, Mar 21, 9:05 AM
Unknown Object (File)
Thu, Mar 16, 4:15 PM
Unknown Object (File)
Wed, Mar 8, 4:23 PM
Unknown Object (File)
Wed, Mar 8, 4:23 PM
Unknown Object (File)
Wed, Mar 8, 11:52 AM
Subscribers

Details

Reviewers
kamil
tomek
michal
Summary

issue: https://linear.app/comm/issue/ENG-3176/make-pressing-a-drawer-item-in-chat-tab-filter-available-chats
Adding to handlers for drawer items expanded state. This is now kept by the wrappe of CommunityDrawerItem - CommunityDrawerItemChat. But since we need expanded to be handled by
CommunityDrawerItemCommunityHandler for CommunityDrawerItemCommunity, we will handle it in the handler for CommunityDrawerItemChat as well, for better code clarity. These fileds will ne
used in the next diff.

Test Plan

texted with the next diff

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka requested review of this revision.Tue, Mar 7, 4:06 AM
web/sidebar/community-drawer-item-handlers.react.js
44–46

You can define things that don't depend on props outside the component so that renders don't recreate them.