Page MenuHomePhabricator

[web] Add expanded and toggleExpanded to CommunityDrawerItemHandler type
ClosedPublic

Authored by inka on Mar 7 2023, 3:51 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Feb 22, 1:33 AM
Unknown Object (File)
Wed, Feb 21, 7:17 AM
Unknown Object (File)
Wed, Feb 21, 4:05 AM
Unknown Object (File)
Wed, Feb 21, 1:44 AM
Unknown Object (File)
Wed, Feb 21, 1:44 AM
Unknown Object (File)
Tue, Feb 20, 11:35 PM
Unknown Object (File)
Tue, Feb 20, 11:35 PM
Unknown Object (File)
Tue, Feb 20, 11:35 PM
Subscribers

Details

Summary

issue: https://linear.app/comm/issue/ENG-3176/make-pressing-a-drawer-item-in-chat-tab-filter-available-chats
Adding to handlers for drawer items expanded state. This is now kept by the wrappe of CommunityDrawerItem - CommunityDrawerItemChat. But since we need expanded to be handled by
CommunityDrawerItemCommunityHandler for CommunityDrawerItemCommunity, we will handle it in the handler for CommunityDrawerItemChat as well, for better code clarity. These fileds will ne
used in the next diff.

Test Plan

texted with the next diff

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inka requested review of this revision.Mar 7 2023, 4:06 AM
web/sidebar/community-drawer-item-handlers.react.js
44–46 ↗(On Diff #23488)

You can define things that don't depend on props outside the component so that renders don't recreate them.

This revision is now accepted and ready to land.Mar 31 2023, 5:37 AM