Paths

Table of Contentst

Differential D6968

[web] Add to redux state picked community in the Chat tab
ClosedPublic
Actions

Authored by inka on Mar 7 2023, 2:58 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Oct 21, 5:59 PM

	Unknown Object (File)
	Sat, Oct 19, 10:24 AM

	Unknown Object (File)
	Fri, Oct 18, 10:11 AM

	Unknown Object (File)
	Thu, Oct 17, 6:36 AM

	Unknown Object (File)
	Thu, Oct 17, 6:36 AM

	Unknown Object (File)
	Thu, Oct 17, 6:36 AM

	Unknown Object (File)
	Thu, Oct 17, 6:36 AM

	Unknown Object (File)
	Thu, Oct 17, 6:33 AM

Subscribers

Details

Reviewers

kamil
tomek
michal

Commits

rCOMM8357aeabc5ca: [web] Add to redux state picked community in the Chat tab

Summary

We will need the information about the selected community in the Chat drawer to be accesable from different parts of the code. For this reason we will keep it in the redux state, just like we
already keep the selected community for the claendar tab in redux.
isse: https://linear.app/comm/issue/ENG-3176/make-pressing-a-drawer-item-in-chat-tab-filter-available-chats

Test Plan

Rub web app, checked that selecting a community in calendar still works

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.Mar 7 2023, 2:58 AM

Herald added subscribers: atul, ashoat. · View Herald TranscriptMar 7 2023, 2:58 AM

inka mentioned this in D6969: [web] Add to reducer logic handling community id picked in chat.Mar 7 2023, 3:02 AM

inka added a child revision: D6969: [web] Add to reducer logic handling community id picked in chat.Mar 7 2023, 3:02 AM

Harbormaster completed remote builds in B17141: Diff 23481.Mar 7 2023, 3:14 AM

inka requested review of this revision.Mar 7 2023, 3:14 AM

kamil accepted this revision.Mar 8 2023, 2:39 AM

kamil added inline comments.

web/redux/redux-setup.js
63–66 ↗	(On Diff #23481)	can you make those read-only?
81 ↗	(On Diff #23481)	feeling confused about this naming, maybe simply `pickedCommunities: PickedCommunities,` will be better? But leaving this up to you

This revision is now accepted and ready to land.Mar 8 2023, 2:39 AM

tomek added inline comments.Mar 8 2023, 5:12 AM

web/redux/redux-setup.js
81 ↗	(On Diff #23481)	how about `communityPickerStore`?

Address review

inka added a child revision: D7341: [web] Move reducing logic for picking a community to its own reducer.Apr 7 2023, 6:44 AM

inka removed a child revision: D6969: [web] Add to reducer logic handling community id picked in chat.

Harbormaster completed remote builds in B18078: Diff 24778.Apr 7 2023, 6:56 AM

Add to initialReduxStateValidator communityPickerStore

@michal can you please tell me if this is all I need to do regarding your validation changes, and if this is a correct type?

inka added 1 blocking reviewer(s): michal.May 22 2023, 12:24 PM

This revision now requires review to proceed.May 22 2023, 12:24 PM

Harbormaster completed remote builds in B19617: Diff 26813.May 22 2023, 12:42 PM

Lgtm

This revision is now accepted and ready to land.May 23 2023, 12:33 AM

Closed by commit rCOMM8357aeabc5ca: [web] Add to redux state picked community in the Chat tab (authored by • InkaSokolowska). · Explain WhyMay 23 2023, 1:00 AM

This revision was automatically updated to reflect the committed changes.

• InkaSokolowska added a commit: rCOMM8357aeabc5ca: [web] Add to redux state picked community in the Chat tab.

• InkaSokolowska mentioned this in rCOMM7be3a7708d1b: [web] Add to reducer logic handling community id picked in chat.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

responders/

website-responders.js

5 lines

web/

redux/

17 lines

selectors/

calendar-selectors.js

8 lines

thread-selectors.js

2 lines

sidebar/

community-drawer-item-handlers.react.js

4 lines

Diff 26823

keyserver/src/responders/website-responders.js

Loading...

web/redux/redux-setup.js

Loading...

web/selectors/calendar-selectors.js

Loading...

web/selectors/thread-selectors.js

Loading...

web/sidebar/community-drawer-item-handlers.react.js

Loading...