Page MenuHomePhabricator

[web] Add to redux state picked community in the Chat tab
AcceptedPublic

Authored by inka on Tue, Mar 7, 2:58 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 16, 11:37 PM
Unknown Object (File)
Wed, Mar 8, 4:21 PM
Unknown Object (File)
Wed, Mar 8, 4:21 PM
Unknown Object (File)
Wed, Mar 8, 11:51 AM
Subscribers

Details

Reviewers
kamil
tomek
michal
Summary

We will need the information about the selected community in the Chat drawer to be accesable from different parts of the code. For this reason we will keep it in the redux state, just like we
already keep the selected community for the claendar tab in redux.
isse: https://linear.app/comm/issue/ENG-3176/make-pressing-a-drawer-item-in-chat-tab-filter-available-chats

Test Plan

Rub web app, checked that selecting a community in calendar still works

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka requested review of this revision.Tue, Mar 7, 3:14 AM
kamil added inline comments.
web/redux/redux-setup.js
63–66

can you make those read-only?

81

feeling confused about this naming, maybe simply pickedCommunities: PickedCommunities, will be better? But leaving this up to you

This revision is now accepted and ready to land.Wed, Mar 8, 2:39 AM
web/redux/redux-setup.js
81

how about communityPickerStore?