Page MenuHomePhabricator
Differential D6975

[web] Add expanded and toggleExpanded to CommunityDrawerItemHandler type
ClosedPublic
Actions

Authored by inka on Mar 7 2023, 3:51 AM.
Tags
None
Referenced Files
F1662709: D6975.diff
Thu, Apr 25, 6:05 AM
Unknown Object (File)
Wed, Apr 10, 12:21 AM
Unknown Object (File)
Thu, Apr 4, 10:10 PM
Unknown Object (File)
Thu, Apr 4, 10:10 PM
Unknown Object (File)
Thu, Apr 4, 10:10 PM
Unknown Object (File)
Thu, Apr 4, 10:10 PM
Unknown Object (File)
Thu, Apr 4, 10:09 PM
Unknown Object (File)
Thu, Apr 4, 10:02 PM
View All 67 Files
Subscribers
ashoat
atul

Details

Reviewers
kamil
tomek
michal
Commits
rCOMMc55146e4cd2f: [web] Add expanded and toggleExpanded to CommunityDrawerItemHandler type
Summary

issue: https://linear.app/comm/issue/ENG-3176/make-pressing-a-drawer-item-in-chat-tab-filter-available-chats
Adding to handlers for drawer items expanded state. This is now kept by the wrappe of CommunityDrawerItem - CommunityDrawerItemChat. But since we need expanded to be handled by
CommunityDrawerItemCommunityHandler for CommunityDrawerItemCommunity, we will handle it in the handler for CommunityDrawerItemChat as well, for better code clarity. These fileds will ne
used in the next diff.

Test Plan

texted with the next diff

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Mar 7 2023, 3:51 AM
Herald added subscribers: atul, ashoat. · View Herald TranscriptMar 7 2023, 3:51 AM
inka added a parent revision: D6974: [web] Add handlers for drawer community items.Mar 7 2023, 3:51 AM
inka added a child revision: D6976: [web] Use new handlers in communnity drawer.Mar 7 2023, 3:55 AM
Harbormaster completed remote builds in B17148: Diff 23488.Mar 7 2023, 4:06 AM
inka requested review of this revision.Mar 7 2023, 4:06 AM
tomek added inline comments.Mar 8 2023, 5:33 AM
web/sidebar/community-drawer-item-handlers.react.js
44–46

You can define things that don't depend on props outside the component so that renders don't recreate them.

tomek accepted this revision.Mar 31 2023, 5:37 AM
This revision is now accepted and ready to land.Mar 31 2023, 5:37 AM
inka mentioned this in D6974: [web] Add handlers for drawer community items.Apr 7 2023, 7:01 AM
inka updated this revision to Diff 24790.Apr 7 2023, 7:03 AM

Address review

Harbormaster completed remote builds in B18090: Diff 24790.Apr 7 2023, 7:26 AM
inka updated this revision to Diff 26749.May 22 2023, 3:28 AM

Rebase

Harbormaster completed remote builds in B19568: Diff 26749.May 22 2023, 3:46 AM
Closed by commit rCOMMc55146e4cd2f: [web] Add expanded and toggleExpanded to CommunityDrawerItemHandler type (authored by • InkaSokolowska). · Explain WhyMay 23 2023, 1:01 AM
This revision was automatically updated to reflect the committed changes.
• InkaSokolowska added a commit: rCOMMc55146e4cd2f: [web] Add expanded and toggleExpanded to CommunityDrawerItemHandler type.

Revision Contents
Changeset List

Diff 23488

View Options

web/sidebar/community-drawer-item-handler.react.js

Loading...
View Options

web/sidebar/community-drawer-item-handlers.react.js

Loading...