HomePhabricator
Diffusion Comm 5e6732ede2db

[native] Fix up issues from D13175

Description

[native] Fix up issues from D13175

Summary:

  1. Prettier does not run on flow-typed to avoid applying changes to libdefs that come from upstream. As such, it's important that we manually fix up whitespace issues.
  2. In libdefs, we should always be specific between {| |} and { ... }, and never just use {}
  3. We should prefer type to interface whenever possible to avoid complex inheritance-based typing
  4. We should maintain consistent style across the file. This diff replaces the inconsistent ; that was introduced in D13175 with , that matches the rest of the file
  5. We should always makes types read-only unless they need to be written to

Test Plan: Flow

Reviewers: inka, tomek

Reviewed By: inka, tomek

Differential Revision: https://phab.comm.dev/D13263

Details

Provenance
ashoatAuthored on Sep 6 2024, 12:01 PM
Reviewer
inka
Differential Revision
D13263: [native] Fix up issues from D13175
Parents
rCOMM6b3f5d4e2047: Fix broken collapsable notifs in badge only threads on iOS
Branches
Unknown
Tags
Unknown