HomePhabricator
Diffusion Comm 5fd125e47f79

[web] [fix] Replace `overflow: scroll` with `auto` to automatically hide…

Tags
None
Referenced Files
F45642: Screenshot_Google Chrome_2022-04-26_140529@2x.png
Apr 26 2022, 7:52 AM
F45638: Screenshot_Google Chrome_2022-04-26_140421@2x.png
Apr 26 2022, 7:52 AM
F45645: Screenshot_Google Chrome_2022-04-26_140548@2x.png
Apr 26 2022, 7:52 AM
F45639: Screenshot_Google Chrome_2022-04-26_140442.png
Apr 26 2022, 7:52 AM
Subscribers
None

Description

[web] [fix] Replace overflow: scroll with auto to automatically hide scrollbars

Summary:
After Tomek's comment in D3742, I noticed, that I used overflow: scroll in my past diffs, what caused scrollbars to appear even if they weren't necessary.
I missed it, because of "Show scroll bars" setting in macOS set to "when scrolling".
After the change sidebars should not appear in Subchannels and Members modals if there is no need to use them.

Before:

Screenshot_Google Chrome_2022-04-26_140442.png (1×998 px, 94 KB)

Screenshot_Google Chrome_2022-04-26_140548@2x.png (1×880 px, 74 KB)

After:
Screenshot_Google Chrome_2022-04-26_140421@2x.png (1×988 px, 93 KB)

Screenshot_Google Chrome_2022-04-26_140529@2x.png (1×888 px, 73 KB)

Test Plan: Confirmed that these are the only uses of overflow: scroll in web app. Launched Subchannels and Members modals with different macOS scrollbar settings to confirm they look correctly.

Reviewers: palys-swm

Reviewed By: palys-swm

Subscribers: ashoat, Adrian, atul, karol-bisztyga, yayabosh

Differential Revision: https://phabricator.ashoat.com/D3854