Page MenuHomePhabricator

[web] [fix] Replace `overflow: scroll` with `auto` to automatically hide scrollbars
ClosedPublic

Authored by jacek on Apr 26 2022, 5:01 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 5, 3:55 AM
Unknown Object (File)
Sun, Oct 27, 6:05 PM
Unknown Object (File)
Sun, Oct 27, 6:05 PM
Unknown Object (File)
Sun, Oct 27, 6:05 PM
Unknown Object (File)
Mon, Oct 21, 2:13 PM
Unknown Object (File)
Sat, Oct 19, 5:46 PM
Unknown Object (File)
Thu, Oct 17, 6:31 AM
Unknown Object (File)
Wed, Oct 9, 7:07 PM

Details

Summary

After Tomek's comment in D3742, I noticed, that I used overflow: scroll in my past diffs, what caused scrollbars to appear even if they weren't necessary.
I missed it, because of "Show scroll bars" setting in macOS set to "when scrolling".
After the change sidebars should not appear in Subchannels and Members modals if there is no need to use them.

Before:

Screenshot_Google Chrome_2022-04-26_140442.png (1×998 px, 94 KB)

Screenshot_Google Chrome_2022-04-26_140548@2x.png (1×880 px, 74 KB)

After:
Screenshot_Google Chrome_2022-04-26_140421@2x.png (1×988 px, 93 KB)

Screenshot_Google Chrome_2022-04-26_140529@2x.png (1×888 px, 73 KB)

Test Plan

Confirmed that these are the only uses of overflow: scroll in web app. Launched Subchannels and Members modals with different macOS scrollbar settings to confirm they look correctly.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jacek edited the summary of this revision. (Show Details)
jacek added 1 blocking reviewer(s): tomek.

Could you maybe search the whole codebase and check if we're using overflow: scroll anywhere?

This revision is now accepted and ready to land.Apr 26 2022, 7:18 AM
In D3854#106911, @palys-swm wrote:

Could you maybe search the whole codebase and check if we're using overflow: scroll anywhere?

I've done it already. These are the only ones.

In D3854#106929, @def-au1t wrote:
In D3854#106911, @palys-swm wrote:

Could you maybe search the whole codebase and check if we're using overflow: scroll anywhere?

I've done it already. These are the only ones.

That's great! Thanks for doing that!