[web] [fix] Replace `overflow: scroll` with `auto` to automatically hide scrollbars
ClosedPublic
Actions

Authored by • jacek on Apr 26 2022, 5:01 AM.

Details

Reviewers

tomek

Commits

rCOMM5fd125e47f79: [web] [fix] Replace `overflow: scroll` with `auto` to automatically hide…

Summary

After Tomek's comment in D3742, I noticed, that I used overflow: scroll in my past diffs, what caused scrollbars to appear even if they weren't necessary.
I missed it, because of "Show scroll bars" setting in macOS set to "when scrolling".
After the change sidebars should not appear in Subchannels and Members modals if there is no need to use them.

Before:

Screenshot_Google Chrome_2022-04-26_140442.png (1×998 px, 94 KB)

Screenshot_Google Chrome_2022-04-26_140548@2x.png (1×880 px, 74 KB)

After:

Screenshot_Google Chrome_2022-04-26_140421@2x.png (1×988 px, 93 KB)

Screenshot_Google Chrome_2022-04-26_140529@2x.png (1×888 px, 73 KB)

Test Plan

Confirmed that these are the only uses of overflow: scroll in web app. Launched Subchannels and Members modals with different macOS scrollbar settings to confirm they look correctly.

Diff Detail

Repository

rCOMM Comm

Branch

jacek/fix-overflow

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• jacek created this revision.Apr 26 2022, 5:01 AM

Herald added subscribers: • abosh, • karol, atul and 2 others. · View Herald TranscriptApr 26 2022, 5:01 AM

• jacek published this revision for review.Apr 26 2022, 5:06 AM

• jacek edited the summary of this revision. (Show Details)

• jacek added 1 blocking reviewer(s): tomek.

Harbormaster completed remote builds in B8547: Diff 11913.Apr 26 2022, 5:06 AM

Could you maybe search the whole codebase and check if we're using overflow: scroll anywhere?

This revision is now accepted and ready to land.Apr 26 2022, 7:18 AM

In D3854#106911, @palys-swm wrote:

Could you maybe search the whole codebase and check if we're using overflow: scroll anywhere?

I've done it already. These are the only ones.

rebase

Harbormaster completed remote builds in B8550: Diff 11916.Apr 26 2022, 7:50 AM

In D3854#106929, @def-au1t wrote:

In D3854#106911, @palys-swm wrote:

Could you maybe search the whole codebase and check if we're using overflow: scroll anywhere?

I've done it already. These are the only ones.