HomePhabricator
Diffusion Comm 6232b76cb106

[identity] Remove deprecated conversion traits

Description

[identity] Remove deprecated conversion traits

Summary:
After legacy device list code was removed, the conversion traits were no longer used. This removes them and replaces last usages with the proper calls from comm-lib. This will also simplify the social proof fix (next diffs).

I had to add implementation for optional attributes to comm-lib, since it was missing.

Depends on D10701

Test Plan:

  • Identity integration tests
  • Unit tests for comm-lib to test optional attributes

Reviewers: michal, varun

Reviewed By: varun

Subscribers: ashoat, tomek

Differential Revision: https://phab.comm.dev/D10762

Details

Provenance
bartekAuthored on Jan 22 2024, 1:36 AM
Reviewer
varun
Differential Revision
D10762: [identity] Remove deprecated conversion traits
Parents
rCOMMd331457cce96: [native] Backup log upload
Branches
Unknown
Tags
Unknown