HomePhabricator
Diffusion Comm 63bd46b9c15c

[lib] Wrap spinPromises in ignorePromiseRejections

Description

[lib] Wrap spinPromises in ignorePromiseRejections

Summary:
The unused-promise Flow lint revealed an issue here. We use SequentialPromiseResolver in keyserver, where an unhandled promise rejection could crash the whole server. But we aren't doing anything to handle a potential promise rejection here.

This diff wraps spinPromises in ignorePromiseRejections. This way, if the promise rejects we will print an error instead of crashing the whole keyserver.

Depends on D10160

Test Plan: Flow

Reviewers: michal

Reviewed By: michal

Subscribers: tomek

Differential Revision: https://phab.comm.dev/D10161

Details

Provenance
ashoatAuthored on Dec 1 2023, 1:28 PM
Reviewer
michal
Differential Revision
D10161: [lib] Wrap spinPromises in ignorePromiseRejections
Parents
rCOMM8be7623397eb: [lib] Don't return a promise from ignorePromiseRejections
Branches
Unknown
Tags
Unknown