HomePhabricator
Diffusion Comm 65bf7357d7b4

[lib][native] Disambiguate URIs in media-cache

Description

[lib][native] Disambiguate URIs in media-cache

Summary:
Part of ENG-3975.
Now the holder isn't accurate, I decided to name this value blobURI because it is of format: either https://keyserver/uploads/... or blob-service://blob-hash.

For media cache, we have two kind of URIs: blobURI - a cache key, and localURI/mediaURI which is a URI to local multimedia file. I needed to rename these accordingly

In short:

  • holder -> blobURI
  • uri -> mediaURI
  • Added some more comments

Depends on D8323

Test Plan: Flow, also ran the native app, cleared media cache and ensured that encrypted multimedia are still displayed as expected. Also did some debugging to check if they're loading from cache

Reviewers: atul, ashoat

Reviewed By: atul

Subscribers: tomek

Differential Revision: https://phab.comm.dev/D8324

Details

Provenance
bartekAuthored on Jun 22 2023, 2:14 PM
Reviewer
atul
Differential Revision
D8324: [lib][native] Disambiguate URIs in media-cache
Parents
rCOMM52f0b0dcb3e8: [native] Rename holder prop to blobURI
Branches
Unknown
Tags
Unknown