HomePhabricator
Diffusion Comm 678e0b544ba7

[web] Turn `LoginModal` into a functional component

Description

[web] Turn LoginModal into a functional component

Summary:
This should be a noop.

(I double checked this diff a few times, but one area that I'm generally not super solid on is useRef so that might be a place to focus on during review?)

Next diffs:

  1. Pull most of this component out into a separate LoginForm component and use within LoginModal.
  2. Render LoginForm in Splash component.

Test Plan:

  • Was able to log in as before.
  • Tried different error scenarios (missing fields, nonexistent username, incorrect password) and ensured that I got the right error messages and the correct inputs were focused.

Reviewers: ashoat, palys-swm

Reviewed By: ashoat, palys-swm

Subscribers: Adrian, karol-bisztyga, benschac

Differential Revision: https://phabricator.ashoat.com/D3456

Details

Provenance
atulAuthored on Mar 17 2022, 2:35 PM
Reviewer
ashoat
Differential Revision
D3456: [web] Turn `LoginModal` into a functional component
Parents
rCOMMaecb238e4d71: [services] Backup - remove auth from implementation
Branches
Unknown
Tags
Unknown