HomePhabricator
Diffusion Comm 67a5bdca2dc0

[lib] Remove `skipMemberAdminRoleCheck` option from…

Description

[lib] Remove skipMemberAdminRoleCheck option from threadIsWithBlockedUserOnly

Summary:
Instead of having a boolean flag, we have a separate threadIsWithBlockedUserOnlyWithoutAdminRoleCheck function which skips the admin role check.

threadIsWithBlockedUserOnly takes LegacyRawThreadInfo | RawThreadInfo and goes through "traditional" admin role check
threadIsWithBlockedUserOnlyWithoutAdminRoleCheck takes only ThreadInfo and handles admin role check "before" via hook


Depends on D12293

Test Plan: flow + close reading

Reviewers: ashoat, ginsu, tomek, varun

Reviewed By: ashoat, tomek

Differential Revision: https://phab.comm.dev/D12294

Details

Provenance
atulAuthored on Jun 17 2024, 11:49 AM
Reviewer
ashoat
Differential Revision
D12294: [lib] Remove `skipMemberAdminRoleCheck` option from `threadIsWithBlockedUserOnly`
Parents
rCOMMfb4e8fe802ab: [terraform] bump staging identity to 0.24-staging
Branches
Unknown
Tags
Unknown