HomePhabricator
Diffusion Comm 6a650e3111e6

[lib] add relative user info to users in messageReactionInfo

Description

[lib] add relative user info to users in messageReactionInfo

Summary:
Right now users in messageReactionInfo returns a set of user ids of all the users who have liked a message. Now that we want to show information about the user like their username, I needed to convert users from a set of user IDs to an array of RelativeUserInfos. Also needed to make some changes to the reaction-utils test suite since we are no longer using a set as our data structure.


Linear Task: ENG-2718

Test Plan:
Logged out messageReactionInfo to show that my changes are behaving as expected (see screenshots below):

Before:

Screenshot 2023-01-18 at 11.42.56 AM.png (1×3 px, 1 MB)

After:

Screenshot 2023-01-18 at 11.41.10 AM.png (1×3 px, 1 MB)

Reviewers: tomek, atul

Reviewed By: tomek

Subscribers: ashoat, tomek, atul

Differential Revision: https://phab.comm.dev/D6301

Details

Provenance
ginsuAuthored on Jan 20 2023, 11:36 AM
Reviewer
tomek
Differential Revision
D6301: [lib] add relative user info to users in messageReactionInfo
Parents
rCOMM2adf8782038a: [lib] remove the word reply/replies from InlineEngagement
Branches
Loading...
Tags
Loading...