HomePhabricator
Diffusion Comm 6a78eaa9b97b

[web] [fix] give chat thread list breadCrumbs height

Tags
None
Referenced Files
F18751: Image 2022-03-08 at 11.38.18 AM.jpg
Mar 8 2022, 12:12 PM
F18752: Image 2022-03-08 at 11.40.49 AM.jpg
Mar 8 2022, 12:12 PM
Subscribers
None

Description

[web] [fix] give chat thread list breadCrumbs height

Summary:
chat thread arrow layout is broken without breadcrumbs. If there isn't a parent thread, will just default to the thread name to not break the UI.

ios:

Image 2022-03-08 at 11.38.18 AM.jpg (1×1 px, 706 KB)

web:
Image 2022-03-08 at 11.40.49 AM.jpg (2×2 px, 942 KB)

https://linear.app/comm/issue/ENG-809/thread-arrows-are-not-aligned-correctly

Test Plan: arrow shouldn't loose it position if there isn't a parnet element. You can patch the code and toggle the conditional to see that the arrows layout never breaks.

Reviewers: ashoat, atul

Reviewed By: ashoat, atul

Subscribers: atul, ashoat, palys-swm, Adrian, karol-bisztyga

Differential Revision: https://phabricator.ashoat.com/D3328

Details

Provenance
benschacAuthored on Mar 8 2022, 12:11 PM
Reviewer
ashoat
Differential Revision
D3328: [web] [fix] give chat thread list breadCrumbs height
Parents
rCOMMc94bd22e8286: [web] Fix sidebar hover styling in `ChatThreadListSidebar`
Branches
Unknown
Tags
Unknown