HomePhabricator
Diffusion Comm 6bbac957a45f

[native][web] Queue new ops

Description

[native][web] Queue new ops

Summary:
Queue operations only if they generate ops or if they have a message ID. All the other cases doesn't need to affect the queue.
The reducer had to be split in two - the ops are modified in platform-specific reducers so we need to add to queues from there. But then it is really challenging to type the reducer correctly, because it doesn't know anything about platform-specific actions and yet it needs to accept these. (Typing as BaseAction | { actionID, ...} doesn't fix the issue because the inexact object is confused with base actions).

https://linear.app/comm/issue/ENG-7097/put-the-ops-into-the-filed-when-reducers-return-them

Depends on D11281

Test Plan: On both web and native check if the ops are being added to queues.

Reviewers: kamil, inka, will

Reviewed By: kamil

Subscribers: ashoat

Differential Revision: https://phab.comm.dev/D11284

Details

Provenance
tomekAuthored on Mar 8 2024, 9:06 AM
Reviewer
kamil
Differential Revision
D11284: [native][web] Queue new ops
Parents
rCOMMb80ef60087c4: [lib] Add an optional ID field to all the actions
Branches
Unknown
Tags
Unknown