HomePhabricator
Diffusion Comm 6ee32d15dceb

[native] Get rid of `mediaProcessConfig` and pass `processMedia` config directly

Tags
None
Referenced Files
F492344: 35b267.png
Apr 18 2023, 7:09 AM
File Not Attached
Subscribers
None

Description

[native] Get rid of mediaProcessConfig and pass processMedia config directly

Summary:
Originally, I just moved the definition of onTranscodingProgress outside of the mediaProcessConfig function: D7475... but on second thought I think we can remove mediaProcessConfig altogether.

Constructing the MediaProcessConfig directly is a lot simpler and removes unnecesary indirection.

(I'm NOT planning any other InputStateContainer refactors. Noticed this because I was looking specifically at processMedia for image avatar work and it was a 2min change)

Test Plan:
flow/careful reading

transcoding progress appears correctly:

35b267.png (534×598 px, 258 KB)

Reviewers: ashoat, ginsu

Reviewed By: ashoat

Subscribers: tomek

Differential Revision: https://phab.comm.dev/D7477

Details