HomePhabricator
Diffusion Comm 72a3200ceb2c

[lib] Update id constants

Description

[lib] Update id constants

Summary:
ENG-4595
Not all ids were converted

Test Plan:

  • for bots.js -> added a console.log in keyserver and web code and checked that only web had a prefix
  • for comm-staff-community (I replaced 311733 with id of one of communities on my dev env for testing)
    • checked id: '311733', sent an image on web, confirmed that there is no "encryptionKey" in extra column in uploads
    • checked id: process.env['KEYSERVER'] ? '311733' : '256|311733', sent an image on web, confirmed that there is "encryptionKey"
  • Searched for id: ', id = ', '1, '2 etc. (case insensitive) and checked if there are any other constants
  • Checked files in facts/ for any id constants

Reviewers: tomek, bartek

Reviewed By: tomek, bartek

Subscribers: ashoat

Differential Revision: https://phab.comm.dev/D8745

Details

Provenance
Michal Gniadek <michal.gniadek@swmansion.com>Authored on Aug 7 2023, 1:43 AM
Reviewer
tomek
Differential Revision
D8745: [lib] Update id constants
Parents
rCOMMc054a1e8ba3f: [lib] Handle new id schema in thread regexes
Branches
Unknown
Tags
Unknown

Event Timeline

Michal Gniadek <michal.gniadek@swmansion.com> committed rCOMM72a3200ceb2c: [lib] Update id constants (authored by Michal Gniadek <michal.gniadek@swmansion.com>).Aug 7 2023, 6:34 AM