Page MenuHomePhabricator
Differential D8745

[lib] Update id constants
ClosedPublic
Actions

Authored by michal on Aug 7 2023, 3:49 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jul 1, 11:51 PM
Unknown Object (File)
Mon, Jul 1, 11:11 PM
Unknown Object (File)
Tue, Jun 11, 11:26 PM
Unknown Object (File)
Mon, Jun 10, 7:24 PM
Unknown Object (File)
May 19 2024, 12:19 AM
Unknown Object (File)
Apr 8 2024, 9:34 PM
Unknown Object (File)
Apr 8 2024, 9:34 PM
Unknown Object (File)
Apr 4 2024, 1:03 AM
View All 22 Files
Subscribers
ashoat

Details

Reviewers
tomek
bartek
Commits
rCOMM72a3200ceb2c: [lib] Update id constants
Summary

ENG-4595
Not all ids were converted

Test Plan
  • for bots.js -> added a console.log in keyserver and web code and checked that only web had a prefix
  • for comm-staff-community (I replaced 311733 with id of one of communities on my dev env for testing)
    • checked id: '311733', sent an image on web, confirmed that there is no "encryptionKey" in extra column in uploads
    • checked id: process.env['KEYSERVER'] ? '311733' : '256|311733', sent an image on web, confirmed that there is "encryptionKey"
  • Searched for id: ', id = ', '1, '2 etc. (case insensitive) and checked if there are any other constants
  • Checked files in facts/ for any id constants

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
facts/
2 lines
2 lines

Diff 29581

View Options

lib/facts/bots.js

Loading...
View Options

lib/facts/comm-staff-community.js

Loading...