HomePhabricator
Diffusion Comm 73bb16e27bfd

[native] add safe area insets for android action sheet

Description

[native] add safe area insets for android action sheet

Summary:
Another thing I encountered when testing the action sheet for the edit avatar flow on android is that if the nav buttons are visible then it partly covers the most bottom option on the action sheet. To fix this I used SafeAreaContext to set the paddingBottom of the action sheet which fixes the issue.

Depends on D7456

Test Plan:
Please check out the screenshots to see the changes I made

Before:

Screenshot 2023-04-16 at 1.26.56 PM.png (1×978 px, 843 KB)

After:

Screenshot 2023-04-16 at 1.28.50 PM.png (1×978 px, 841 KB)

w/o nav buttons:

Screenshot 2023-04-16 at 1.30.00 PM.png (1×978 px, 589 KB)

Reviewers: ashoat, atul

Reviewed By: ashoat

Subscribers: ashoat, tomek, atul

Differential Revision: https://phab.comm.dev/D7457

Details

Provenance
ginsuAuthored on Apr 16 2023, 3:40 PM
Reviewer
ashoat
Differential Revision
D7457: [native] add safe area insets for android action sheet
Parents
rCOMM39a557c86168: [native] fix Android cancel action sheet crash
Branches
Unknown
Tags
Unknown