HomePhabricator
Diffusion Comm 78707c7daef9

[web] Update the change role icon on web

Description

[web] Update the change role icon on web

Summary:
The icon for the change role action item in the members modal is currently a plus-circle. After some discussion, we need to use the new edit-1 icon part of the CommIcon component.

MenuItem defaults to using a SWMansionIcon if a icon name is provided:

let menuItemIcon = iconComponent;
if (icon) {
  menuItemIcon = <SWMansionIcon size="100%" icon={icon} />;
}

so instead I used the existing iconComponent prop to pass in the CommIcon we're using.

Test Plan:
The new icon looks as expected

Screenshot 2023-07-11 at 6.09.25 PM.png (328×956 px, 28 KB)

Reviewers: atul, ginsu

Reviewed By: ginsu

Subscribers: ashoat, tomek

Differential Revision: https://phab.comm.dev/D8479

Details

Provenance
rohanAuthored on Jul 11 2023, 3:07 PM
Reviewer
ginsu
Differential Revision
D8479: [web] Update the change role icon on web
Parents
rCOMM932c409003dd: Revert "[web] Migrate to new id schema"
Branches
Unknown
Tags
Unknown